Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Facebook Authentication Tutorial Should Specify react-apollo version number #543

Open
localjo opened this issue Jul 3, 2018 · 2 comments

Comments

@localjo
Copy link

localjo commented Jul 3, 2018

Current behavior

The tutorial doesn't work when installing the latest version of react-apollo.

Reproduction

Try to work through the tutorial as-is, you'll get stuck on step 18 when you try to run the app.

Expected behavior?

The app should start without errors.

Either the tutorial should be updated to specify installing react-apollo@1.4.15 or the tutorial should be updated to work with react-apollo@2.

@localjo
Copy link
Author

localjo commented Jul 3, 2018

I opened this issue instead of a PR because I wanted to ask the maintainers; would you prefer to update the tutorial to specify react-apollo@1.4.15 or to work with react-apollo@2?

@localjo
Copy link
Author

localjo commented Jul 3, 2018

@dpetrick Would you accept PRs that update the Facebook Authentication tutorial and the guide-starters project to work smoothly with all of the latest updates to dependencies and APIs? I've run into a lot of blockers while working through the tutorial, and I'd be happy to contribute the relevant updates that I've figured out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant