Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Gaussian blur implementation #995

Open
Tracked by #912
Keavon opened this issue Jan 28, 2023 · 5 comments
Open
Tracked by #912

Faster Gaussian blur implementation #995

Keavon opened this issue Jan 28, 2023 · 5 comments
Labels
Feature New feature or request Help Wanted Extra attention is needed Performance Speed and efficiency improvements Rust Involves Rust programming for the backend

Comments

@Keavon
Copy link
Member

Keavon commented Jan 28, 2023

The current implementation of Gaussian Blur runs through each pixel and blurs it with all its neighboring pixels within the kernel radius. That's great for other types of kernels, but the special case of Gaussian Blur can be drastically sped up by blurring just the X axis followed by just the Y axis.

(An even faster approach at larger radius values, using an FFT and IFFT, can be tackled later in another issue.)

@Keavon Keavon added Feature New feature or request Available Rust Involves Rust programming for the backend Performance Speed and efficiency improvements labels Jan 28, 2023
@Keavon Keavon mentioned this issue Feb 11, 2023
@Keavon Keavon added Help Wanted Extra attention is needed Available and removed In-Progress labels May 25, 2023
@Keavon Keavon changed the title Faster Gaussian Blur implementation Faster Gaussian blur implementation Sep 9, 2023
@kbujari
Copy link

kbujari commented Feb 26, 2024

Hi, I'd like to try taking this one on.

@Keavon
Copy link
Member Author

Keavon commented Feb 26, 2024

Last time we tried tackling this, it was blocked by some larger architectural issues. But that might be solved by now. @TrueDoctor do you think this is approachable now, or is it too involved for a beginner?

@Keavon
Copy link
Member Author

Keavon commented Feb 29, 2024

@kbujari I'm told by @TrueDoctor that this is actually not blocked anymore. Please proceed!

@Zamoca42
Copy link

Is this completed? I cannot find the implementation of Gaussian Blur in the current repository.

@Keavon
Copy link
Member Author

Keavon commented Oct 22, 2024

The original slow/broken version was removed. So this issue involves adding one that's as performant as possible on the CPU. Feel free to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Help Wanted Extra attention is needed Performance Speed and efficiency improvements Rust Involves Rust programming for the backend
Projects
Status: Short-Term
Development

No branches or pull requests

4 participants