Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle maps that don't have enUS #161

Open
dsjoerg opened this issue Oct 23, 2013 · 1 comment
Open

handle maps that don't have enUS #161

dsjoerg opened this issue Oct 23, 2013 · 1 comment
Assignees
Milestone

Comments

@dsjoerg
Copy link
Collaborator

dsjoerg commented Oct 23, 2013

https://twitter.com/_celphy/status/393049907101057024

the map is http://EU.depot.battle.net:1119/8b3bce7f9488d824a130cddfff84e84ad460d284a2d9748dd3b08e71605ec66c.s2ma

which has only

enGB.SC2Data\LocalizedData\GameStrings.txt 546 bytes

no enUS.

Due to the issue described here: https://github.com/GraylinKim/sc2reader/blob/master/sc2reader/resources.py#L636

It can't be handled.

Not sure how common this issue is.

@ghost ghost assigned GraylinKim Oct 28, 2013
@GraylinKim
Copy link
Owner

This is probably pretty common for non-Blizzard, non-tournament, non-US maps. Why fill in enUS translations when you don't think your map will ever be played over here. I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants