Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lint-staged for pre-commit hook in if-plugins and if #668

Closed
5 tasks
Tracked by #651
jmcook1186 opened this issue Apr 25, 2024 · 2 comments · Fixed by #713 or Green-Software-Foundation/if-plugins#94
Closed
5 tasks
Tracked by #651
Assignees
Milestone

Comments

@jmcook1186
Copy link
Contributor

jmcook1186 commented Apr 25, 2024

What
Replicate Green-Software-Foundation/if-unofficial-plugins#51 in if and if-plugins repositories

Why
These changes make it easier to develop for IF locally as they prevent the linter from taking unstaged changes into account.

Context
Community cointributor made these changes in the if repository (see Green-Software-Foundation/if-unofficial-plugins#51) now we want the same behaviour to be replicated across the other IF repos.

Prerequisites/resources
none

SoW (scope of work)

Acceptance criteria

  • .husky/pre-commit, .lintstagedrc.js and package.json updated to match https://github.com/Green-Software-Foundation/if-unofficial-plugins/pull/51/files
    - the expected behaviour is
    GIVEN a user is developing a plugin or IF feature int heir local environment
    WHEN they commit changes
    THEN the linter should not reject the commit based on the content of unstaged files

  • applied to if and if-pluginsrepositories

  • new flow is tested manually by committing a chanmge to a local copy of the repository

@jmcook1186 jmcook1186 added this to IF Apr 25, 2024
@jmcook1186 jmcook1186 moved this to Ready in IF Apr 25, 2024
@zanete zanete moved this from Ready to Pending Review in IF May 16, 2024
This was linked to pull requests May 17, 2024
@zanete
Copy link

zanete commented May 20, 2024

@manushak please review 🙏

@zanete zanete moved this from Pending Review to Testing in IF May 20, 2024
@manushak
Copy link
Contributor

@manushak please review 🙏

done

@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 21, 2024
@zanete zanete added this to the Improve Trust milestone Jun 5, 2024
@zanete zanete mentioned this issue Jun 5, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants