Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate chi-squared based thresholder #393

Open
astrofle opened this issue Oct 1, 2024 · 0 comments
Open

Incorporate chi-squared based thresholder #393

astrofle opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@astrofle
Copy link
Collaborator

astrofle commented Oct 1, 2024

At some point we should incorporate the chi-squared thresholder developed by @cixue for the https://github.com/cixue/gotham-spectral-pipeline.

I believe the relevant function is: Spectrum.detect_signal, currently in: https://github.com/cixue/gotham-spectral-pipeline/blob/main/gotham_spectral_pipeline/spectrum.py#L667
@astrofle astrofle added the enhancement New feature or request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astrofle