Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Write of flags in SDFITS, Scan, and Spectrum #418

Open
mpound opened this issue Oct 25, 2024 · 0 comments
Open

Read/Write of flags in SDFITS, Scan, and Spectrum #418

mpound opened this issue Oct 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mpound
Copy link
Collaborator

mpound commented Oct 25, 2024

Feature description
Requirements are the abilities to

  1. Read GBTIDL flags
  2. Write applied flags/mask back out from the classes which we support data-writing.
  3. Read flags/masks that have been written to our classes.

Solution

  1. Figure out how to parse GBTIDL flag files into a Flag object, which is then attached to the GBTFITSLoad object
  2. For SDFITS format we would write a new binary table column "FLAGS" that has same dimensions as the "DATA" column and consists of a bitmask. Possibly using https://docs.astropy.org/en/stable/nddata/bitmask.html. For Spectra, there is already a column with the mask value.
  3. Creating a Flag object from SDFITS bitmask may be tricky. Brute force is to make one Flag._flag_selection_rule per row. Channel flags themselves are stored per binary table in SDFITSLoad._flagmask.

Additional context
We will not write out GBTIDL flag format. Also VEGAS flags are covered under issue #30

@mpound mpound added the enhancement New feature or request label Oct 25, 2024
@mpound mpound added this to the Q6 milestone Oct 25, 2024
@mpound mpound self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant