Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action should strip leading v on from tag by default #19

Closed
GeckoEidechse opened this issue Apr 27, 2023 · 3 comments · Fixed by #21
Closed

Action should strip leading v on from tag by default #19

GeckoEidechse opened this issue Apr 27, 2023 · 3 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@GeckoEidechse
Copy link

The convention is to use a leading for version number tags, i.e. git tag v4.2.0 However Thunderstore strictly requires a X.Y.Z version number format, i.e. no leading v.

As such the action should strip the leading v from the tag when generating the version number for Thunderstore.

Alternatively https://github.com/GreenTF/NSModTemplate could be updated to pass a stripped version number to the action instead of github.ref_name ^^

@GeckoEidechse GeckoEidechse changed the title Action should strip leading v on version tag by default Action should strip leading v on from tag by default Apr 27, 2023
@AnActualEmerald
Copy link
Member

This should be the case at the moment, is it not working that way?

@GeckoEidechse
Copy link
Author

@AnActualEmerald
Copy link
Member

Okay, I found the issue 🫡

@AnActualEmerald AnActualEmerald added the bug Something isn't working label Apr 27, 2023
@AnActualEmerald AnActualEmerald mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants