Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Filter: capture reference id and capture uuid filters are broken #1034

Open
gwynndp opened this issue Feb 25, 2023 · 7 comments
Open
Assignees
Labels
priority High priority issue tool: Verify Relates to the capture verification tool (Verify page) type: bug Something isn't working

Comments

@gwynndp
Copy link
Collaborator

gwynndp commented Feb 25, 2023

No description provided.

@gwynndp gwynndp changed the title Verify: Approving a sub-selection of captures is broken Filters are broken Feb 26, 2023
@gwynndp gwynndp changed the title Filters are broken Verify Filter: capture reference id and capture uuid filters are broken Feb 26, 2023
@nmcharlton
Copy link
Collaborator

This might be caused by double-conversion of the where object described here.

@OlhaD
Copy link
Contributor

OlhaD commented Feb 28, 2023

I checked it on the dev environment and found that both filters work but only if you enter an exact match. @gwynndp Is it a desired behaviour or not?
Also, I found that if I put part of the id to the 'capture uuid' filter, I get an error from the backend (""id" must be a valid GUID") which is not handled, and the user sees a spinner which is not hiding. @nmcharlton Should we maybe add an error message to the UI or should it be fine to search by only the part of the id?

@nmcharlton
Copy link
Collaborator

These are slightly odd fields to have in a filter, as they're really lookups that return 0 or 1 matches.
Partial match doesn't really make sense here, since they're system-generated IDs.

The use case for querying by ID like this is extracting the capture ID from another page on the Admin Panel or another system and finding the capture details for inspection or verification. The future workflow will be to encode the filter in the URL so we can link directly with no copying and pasting, including from external systems.

The UX needs to change to reflect this – it's still very basic for most fields. For the UUID in particular, the user should not be able to submit a query with an invalid UUID.

Our error handling from a UX perspective also needs some work. We seem to ignore a lot of errors and just leave the user hanging like this. There are two existing issues that cover this: #473 and #936.

@nmcharlton nmcharlton added tool: Verify Relates to the capture verification tool (Verify page) type: bug Something isn't working good first issue Good for newcomers priority High priority issue size: small Simple change labels Mar 5, 2023
@nmcharlton
Copy link
Collaborator

nmcharlton commented Mar 5, 2023

@OlhaD This isn't working for me on https://dev-admin.treetracker.org.
Do you have it working in your workspace with the filter conversion fix?
If so, are you happy for me to assign this to you?

@nmcharlton nmcharlton removed good first issue Good for newcomers size: small Simple change labels Mar 5, 2023
@OlhaD
Copy link
Contributor

OlhaD commented Apr 3, 2023

@nmcharlton Just double-checked: it doesn't work for me as well. Please, assign it to me.

@OlhaD
Copy link
Contributor

OlhaD commented Apr 3, 2023

@nmcharlton You are right, it was fixed in the scope of #888.

@pranavkparti
Copy link
Contributor

This issue should be marked closed if it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority High priority issue tool: Verify Relates to the capture verification tool (Verify page) type: bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants