Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding page number in page url (enhancement) #1090

Open
SuspenseFallback opened this issue Apr 23, 2023 · 1 comment · May be fixed by #1010
Open

Adding page number in page url (enhancement) #1090

SuspenseFallback opened this issue Apr 23, 2023 · 1 comment · May be fixed by #1010
Assignees
@nmcharlton
Labels
tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) tool: Verify Relates to the capture verification tool (Verify page) type: enhancement New feature or request

Comments

@SuspenseFallback
Copy link
Contributor

Along with adding the filter values in the url (see issue #915 ), for certain pages such as Verify, should the page number, along with the image size and number of images shown be also added as query parameters?
@nmcharlton nmcharlton added the type: enhancement New feature or request label Apr 23, 2023
@nmcharlton nmcharlton self-assigned this Apr 23, 2023
@nmcharlton nmcharlton added tool: Verify Relates to the capture verification tool (Verify page) tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) tool: Captures Relates to the capture data tool (Captures page, formerly Trees) labels Apr 23, 2023
@nmcharlton
Copy link
Collaborator

I think that's a great idea. Page number and images per page are important pieces of view state information that should be retained on refresh and should link into the browser back/forward buttons.

I've already included pagination parameters in the draft PR for the filter persistence: #1010.
I'll link this issue in as resolve by that PR for completeness.

Image size is a little different, as it's more like a user preference – it would make sense to store this in localStorage.

@nmcharlton nmcharlton linked a pull request Apr 23, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmcharlton nmcharlton

Labels
tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) tool: Verify Relates to the capture verification tool (Verify page) type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter bookmark SuspenseFallback/treetracker-admin-client
2 participants
@nmcharlton @SuspenseFallback