-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select for duplicate capture matching check #781
Comments
This sounds like a cool feature. It would be great to get some UX design effort on this. |
A small map with selected captures plotted would be very simple to add to help visualise this feature. |
For anyone looking to pick this up, we have a lat/lon for every capture, so calculation should be very straightforward using |
@nmcharlton and @sebastiangaertner, I can pick this up. Before I get started, I just wanted to make sure on the ask: My questions are:
I think to keep things simple and intuitive, it might be good to keep the distance calc between only two selections and perhaps list that in the SidePanel, if we are displaying distance numerically. If we're displaying things on a small map visually like Nick suggested (which we only need the lat/log for, and not necessarily the numeric distances listed), I think 2-4 makes sense. Please advise!
Thanks! |
@Kpoke meet @amesk3 . I have given Amy a dataset from the legacy DB and as discussed it would make more sense to get this tool developed off the treetracker schema rather. @amesk3 reach out to Daniel to coordinate the data structure to be sure that it reflects the upcoming Domain model migration. We can add this data into dev if we change planter_id and the coordinates by a small value (always the same value) |
Hi @amesk3. Sorry for the delay. What do you think of a simple label with beneath the Select All and Select None buttons?
It could state the greatest pairwise distance of up to four captures (or some reasonable limit given O(N!) computation time), then grey out when too many are selected. Perhaps when one capture is selected, we could also include the distance to that capture in the quick-look tooltip when the user hovers over each of the other captures. |
Hi @nmcharlton , no worries- I was just plugging away! In the example. we are given three lat/long points, NY, Chicago and Johannesburg (the coordinates are real). These three points have been transposed from lat/long to x,y on a html canvas, and the viewport has been focused to show the three points, you can think of these as the checkboxed 'chosen images' in the app. We assume a threshold, and say, according to the threshold, NY and Chicago are too close to each other to be 'different images', however, Johannesburg is far enough in distance that it a different image from the other two. We can color code Chicago and NY as RED to indicate that these two are 'too close' and GREEN for Johannesburg that it is a far enough image from the other two, and thus user does not have to be as worried about it being the image from the same source. Of course, in reality, we will have coords for images of trees, and not cities, and a completely different threshold/viewports to indicate whether the images are 'too close' or 'far enough from each other' to be considered different. Here's the original 'wireframe' that I'm using to guide me in terms of placement of components. Another note: there's not much backend interaction other than fetching the lat/long (which is already being done) and doing the calculations on the frontend to display. If we keep it <5 selected items, I don't think it will take to long to calc the distances and to display them. I'm doing the prototyping in a codesandbox to make it work and then I'll integrate it into the main code. Please let me know if you have any concerns of doing it the above way-- thanks! |
Thinking more about this, @nmcharlton I think it would actually be beneficial to add 'Distance between selected captures: x.x m' like you said, when only two images are selected. For 3 or 4 images I still think the visualizer will be easier to deal with. To me they seem like two different use cases. I can almost see these two being v1 and v2 of this feature-- v1 being the distance display for just two images (simple), and v2 being the visualizer for 1<x<5 (more advanced). Either way, I can do either one or both. Let me know please! |
Sounds great from my side. I think making a v1 version and then testing it for a while and adding specific functionality to it and changing UX is totally legitimate since this is really about intuitive quick comprehension of the information that is conveyed. |
@amesk3 This is fantastic! I love the visualiser as a v2 implementation as you suggest. We may even be able to use a very simple version of the web map for a consistent user experience (assuming it doesn't become to cluttered with a satellite image underneath). I can see users wanting to quickly plot a batch of captures on a map like this to check the trees are distributed as expected. Let's go with the v1 option to address the simple case quickly, then iterate on the visualiser. Great work! |
Thank you! Please see my the PR for the v1 changes! @nmcharlton |
In order to be able to find duplicates with the verify tool it would be amazing if we could select 2 or 3 or 4 images and run a simple distance check. Practically a verifier sees trees that are similiar but can maybe not judge if they are duplicates or not. If we had a simple pop up showing the distance between the points that would be a great start.
The text was updated successfully, but these errors were encountered: