Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Matching: Allow user to specify minimum interval between capture and potential match #949

Open
sebastiangaertner opened this issue Nov 18, 2022 · 14 comments
Labels
size: small Simple change tool: Capture Matching Relates to the Capture Matching tool type: enhancement New feature or request

Comments

@sebastiangaertner
Copy link
Contributor

sebastiangaertner commented Nov 18, 2022

See screenshot below. This is from live data in the beta admin which is now ready for testing.
The images on the right have to be at least 1month older than the one that is matched (left side) here see example.
949

@navDhammu
Copy link

I would like to work on this

@dadiorchen
Copy link
Collaborator

@navDhammu thanks for putting your energy into this, the capture matching tool is the major focus for us these days.

@dadiorchen
Copy link
Collaborator

The situation is, we are going to deliver the beta version to our VIP client freetown, currently, the source of the beta is branch : hotfix/v1.107
so please work on this and raise PR against hotfix/v1.107

Please let me know if you need any support

@nmcharlton
Copy link
Collaborator

nmcharlton commented Nov 19, 2022

@dadiorchen @sebastiangaertner This should be part of the potential_matches logic in treetracker-api rather than in the client. @Kpoke

@dadiorchen
Copy link
Collaborator

@sebastiangaertner I think this rule is a bit overkill, it's possible that the planter revisits the tree within a month, we shouldn't restrain this.

BTW, the dates on the UI is totally wrong, I have corrected it.

@Kpoke
Copy link
Contributor

Kpoke commented Nov 21, 2022

Yeah this issue should be transferred to the treetracker-api

@dadiorchen
Copy link
Collaborator

@sebastiangaertner and I discussed this, to provider good flexibility, we can do:

  1. Add a filter to do: `just some trees in the time range: 1 week, 2 weeks, 1 month...
  2. Set the default value to 1 month, so by default, people just see tree 1 month ago

@nmcharlton nmcharlton changed the title Capture matching tool should not show trees that are within 1 months of the compared image Capture Matching: Allow user to specify minimum interval between capture and potential match Dec 3, 2022
@nmcharlton
Copy link
Collaborator

@dadiorchen @sebastiangaertner
To clarify: We should allow the user to set a time interval (default 4 weeks) and hide potential matches that have any captures within that interval from the capture being matched.
Let's just do that in the client.

I suggest a dropdown above the candidate matches that says:

Hide trees captured within [1 week | 2 weeks | 4 weeks]

I would avoid months as it will give you different behaviour depending on the time of year.

@navDhammu Are you happy to make a start on this?

@nmcharlton nmcharlton added type: enhancement New feature or request tool: Capture Matching Relates to the Capture Matching tool size: small Simple change labels Dec 3, 2022
@navDhammu
Copy link

@dadiorchen @sebastiangaertner To clarify: We should allow the user to set a time interval (default 4 weeks) and hide potential matches that have any captures within that interval from the capture being matched. Let's just do that in the client.

I suggest a dropdown above the candidate matches that says:

Hide trees captured within [1 week | 2 weeks | 4 weeks]

I would avoid months as it will give you different behaviour depending on the time of year.

@navDhammu Are you happy to make a start on this?

Yeah I can try work on this

@dadiorchen
Copy link
Collaborator

@navDhammu if you checkout the hotfix-107 branch, you will find that we have set a default parameter, matching_tree_time_range, that's the parameter for this, so you just need to try to change it on the client side!

@navDhammu
Copy link

@navDhammu if you checkout the hotfix-107 branch, you will find that we have set a default parameter, matching_tree_time_range, that's the parameter for this, so you just need to try to change it on the client side!

I'm not sure what this parameter does. Does it only return potential matches captured after 30 days from the one being matched? At the moment the capture matching tool is not showing any matches in the hotfix-107 branch.

@dadiorchen
Copy link
Collaborator

@navDhammu there is the code:

const req = `${TREETRACKER_API}/captures?tree_associated=false&limit=${1}&offset=${
currentPage - 1
}&${where}&matchting_tree_distance=6&matchting_tree_time_range=30`;

@sebastiangaertner
Copy link
Contributor Author

@dadiorchen Nicks suggestion with a default 30days min interval is good. It's very very unlikely that prga revisit but in some cases they might want to retake the captures and reject the first round or so.

@sebastiangaertner
Copy link
Contributor Author

In case anybody is picking this up. Here is more up to date design file
https://www.figma.com/proto/51iWcFythyfxrP4p4jd5rL/Admin-Panel?node-id=4-22&starting-point-node-id=4%3A22

@navDhammu navDhammu removed their assignment Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small Simple change tool: Capture Matching Relates to the Capture Matching tool type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants