Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grower-detail): display device manufacturer with device id #600

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Nov 13, 2021

Description

Add device manufacturer to the Planter Registration query

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Enhancement

Issue

What is the current behavior?

Only returns info from the planter_registration table at the moment.

What is the new behavior?

Adds a join to the devices table to the query so that the device manufacturer info can be retreived.

Steps taken:

  • Update deviceIdentifier state to include the device OS
  • Display the device id and the OS on the GrowerDetail component

Breaking change

Does this PR introduce a breaking change?

  • No
  • The query for null organizations runs slower than the other queries

Related PR & Issue

Greenstand/treetracker-admin-client#196
#458

Growers - Treetracker Admin by Greenstand 2021-11-13 11-15-50

@gwynndp gwynndp linked an issue Nov 13, 2021 that may be closed by this pull request
@nmcharlton nmcharlton merged commit 7136c9a into Greenstand:master Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Device info on planter detail
2 participants