Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can upload bad file as payment #75

Closed
dadiorchen opened this issue Apr 6, 2022 · 3 comments · Fixed by #76
Closed

Can upload bad file as payment #75

dadiorchen opened this issue Apr 6, 2022 · 3 comments · Fixed by #76
Assignees

Comments

@dadiorchen
Copy link
Contributor

up-badFields.csv
up-badValues.csv

@philnorc
Copy link

philnorc commented Apr 6, 2022

In tests just now (April 6, 16:30 Chicago time)
the tool properly rejected upload files with missing fields or empty values.
It also rejected files with good data values, but without field names in line 1.

@philnorc philnorc moved this from Ready for test to Done in Earnings System Production Readiness Apr 6, 2022
@dadiorchen
Copy link
Contributor Author

@philnorc you mean without the header? I think we can define the file to must have the header as the first line, and it's also a good practice when people open the file with excel, if we don't have the header, it's hard to tell which column is which?

@philnorc
Copy link

philnorc commented Apr 8, 2022

Yes, right, the line 1 of the file must be "earnings_id","worker_id","phone","currency","amount","captures_count","payment_confirmation_id","payment_method","paid_at"

@philnorc philnorc closed this as completed Apr 8, 2022
Repository owner moved this from Done to Ready for test in Earnings System Production Readiness Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants