Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate husky (conventional commits, eslint) #432

Open
Kpoke opened this issue Oct 17, 2023 · 4 comments
Open

Integrate husky (conventional commits, eslint) #432

Kpoke opened this issue Oct 17, 2023 · 4 comments
Assignees
@camchu2001

Comments

@Kpoke
Copy link
Collaborator

Kpoke commented Oct 17, 2023

No description provided.

@Kpoke
Copy link
Collaborator Author

Kpoke commented Oct 17, 2023

Eslint and conventional commit rules should be enforced via husky

@camchu2001
Copy link

I'd like to work on this issue. @Kpoke Do you want me to create a PR for this against the typescript-branch?

@Kpoke
Copy link
Collaborator Author

Kpoke commented Oct 18, 2023

Yes definitely

@camchu2001
Copy link

@Kpoke Please take a look at my PR #435 for this. Please let me know if you want request changes on my PR, I will go ahead and address it.

@camchu2001 camchu2001 mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camchu2001 camchu2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kpoke @camchu2001