Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad practice storing the plaintext password locally #430

Open
Zercerium opened this issue Apr 30, 2024 · 1 comment
Open

bad practice storing the plaintext password locally #430

Zercerium opened this issue Apr 30, 2024 · 1 comment

Comments

@Zercerium
Copy link

at the moment the password ist stored in plaintext (locally). I can reload the page and then toggle the password visible again. instead of this after a login a session token should be returned for verification (imo). At least the password shouldn't be stored in plaintext in local storage, this is definitely a bad practice.

best regards, thanks for your work

@ZonaHex
Copy link
Collaborator

ZonaHex commented Jun 4, 2024

Hello again! Thanks for your insights. This dashboard is mainly used as a web platform for the service of our standalone GreptimeDB. The username and password are used as HTTP authorization headers for GreptimeDB HTTP API. Related dashboard code is here. The basic auth would be passed to the API every time.
Your opinion is absolutely right. I would look into this and find a more safe solution to store the password. You are more than welcome to share other thoughts if you want :)
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants