Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize distributed deletions from gRPC #1708

Closed
MichaelScofield opened this issue Jun 3, 2023 · 2 comments · Fixed by #2150
Closed

Optimize distributed deletions from gRPC #1708

MichaelScofield opened this issue Jun 3, 2023 · 2 comments · Fixed by #2150
Assignees
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements
Milestone

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Refactor

What does the enhancement do?

GRPC delete requests are just like insert requests, carrying the column data for deletions. They both had very similar implementations: splitting the to be inserted/deleted data by partition rules, not parallel or batched, and done in a per table fashion etc.

Now the distributed insertions are optimized in a batch in #1687 , it's time we do that for distributed deletions as well.

Implementation challenges

No response

@MichaelScofield MichaelScofield added C-enhancement Category Enhancements A-frontend Involves code in the Frontend node labels Jun 3, 2023
@NiwakaDev
Copy link
Collaborator

I'd like to work on this issue. Should I first start by implementing DeleteRequests like InsertRequests?:
GreptimeTeam/greptime-proto#47

@MichaelScofield
Copy link
Collaborator Author

@NiwakaDev Yes, I think we should first implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants