Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More properly guard against concurrent schemaless table creations and alterations #1716

Closed
MichaelScofield opened this issue Jun 5, 2023 · 5 comments
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Refactor

What does the enhancement do?

Now the schemaless table creations and alterations are run concurrently (introduced by #1687 ). This could cause some issues when running concurrently. For example, unique table ids are wasted, or unnecessary calls to Metasrv. We should properly guard against it in Frontend.

Implementation challenges

No response

@MichaelScofield MichaelScofield added C-enhancement Category Enhancements A-frontend Involves code in the Frontend node labels Jun 5, 2023
@MichaelScofield
Copy link
Collaborator Author

Although the schemaless table creations and alterations are reverted back to serialized execution now, we can still benifit from adding a lock to control the concurrency, avoiding doing some unnecessary work.

@MichaelScofield MichaelScofield added the good first issue Good for newcomers label Jul 21, 2023
@sunray-ley
Copy link
Contributor

I want to have a try.

@MichaelScofield
Copy link
Collaborator Author

thx @sunray-ley , assigned

@killme2008
Copy link
Contributor

@MichaelScofield Looks like we don't have this problem currently after we used procedures for all DDL statements. Could you check it?

@MichaelScofield
Copy link
Collaborator Author

@killme2008 This problem is gone not because we are using procedure but the schemaless table creations are changed back to serial mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants