Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports TIMESTAMP_MS, TIMESTAMP_S and TIMESTAMP_NS types #2072

Closed
killme2008 opened this issue Aug 2, 2023 · 9 comments
Closed

Supports TIMESTAMP_MS, TIMESTAMP_S and TIMESTAMP_NS types #2072

killme2008 opened this issue Aug 2, 2023 · 9 comments
Assignees
Labels
C-feature Category Features good first issue Good for newcomers
Milestone

Comments

@killme2008
Copy link
Contributor

What problem does the new feature solve?

They are just the alias for the timestamp types with different units.

Hope to run the following SQL:

SELECT DATE '1992-01-01'::TIMESTAMP_MS;

What does the feature do?

Timestamp types alias with different units.

Implementation challenges

No response

@killme2008 killme2008 added the C-feature Category Features label Aug 2, 2023
@waynexia
Copy link
Member

waynexia commented Aug 2, 2023

what does MS mean? Millisecond or Microsecond

@killme2008 killme2008 added the good first issue Good for newcomers label Aug 2, 2023
@killme2008
Copy link
Contributor Author

what does MS mean? Millisecond or Microsecond

Millisecond

@waynexia
Copy link
Member

waynexia commented Aug 2, 2023

Then how to express MicroSecond? Or we can define it as TimestampMilli, TimestampMicro, TimestampSecond, TimestampMillisecond (duplicate some for convenient)

@killme2008
Copy link
Contributor Author

Then how to express MicroSecond? Or we can define it as TimestampMilli, TimestampMicro, TimestampSecond, TimestampMillisecond (duplicate some for convenient)

These names look too long. Maybe we can use timstamp_micros for MicroSecond.

@Gump9
Copy link
Contributor

Gump9 commented Aug 6, 2023

I want to have a try,any example?which file should i change?

@waynexia
Copy link
Member

Also support this grammar:

SELECT TIMESTAMP2020-01-01 01:23:45.12345678’::TIMESTAMP(9);
Error: 3000(PlanQuery), This feature is not implemented: Unsupported SQL type Timestamp(Some(9), None)

@Gump9
Copy link
Contributor

Gump9 commented Aug 17, 2023

Also support this grammar:

SELECT TIMESTAMP2020-01-01 01:23:45.12345678’::TIMESTAMP(9);
Error: 3000(PlanQuery), This feature is not implemented: Unsupported SQL type Timestamp(Some(9), None)

OK,give me some time please,a little busy lately😰

@killme2008
Copy link
Contributor Author

@Gump9 hi, are you still working on this issue? We want to support these types in v0.4

@killme2008 killme2008 assigned killme2008 and unassigned Gump9 Sep 4, 2023
@killme2008 killme2008 mentioned this issue Sep 5, 2023
2 tasks
@Gump9
Copy link
Contributor

Gump9 commented Sep 6, 2023

@Gump9 hi, are you still working on this issue? We want to support these types in v0.4

Sorry, I must finished the school project in the past month, and I haven't had enough time to focus on this issue.🤕️I will try other issue soon,my bad

@killme2008 killme2008 added this to the v0.4 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category Features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants