Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxover broken in gtfn #1289

Open
havogt opened this issue Jul 18, 2023 · 1 comment
Open

maxover broken in gtfn #1289

havogt opened this issue Jul 18, 2023 · 1 comment
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids. module: frontend Frontend subpackage triage: bug Something isn't working

Comments

@havogt
Copy link
Contributor

havogt commented Jul 18, 2023

maxover is failing in C++ because we generate -2147483648 which in c++ is long int because 2147483648 is a long int literal which is then negated. Therefore we try to instantiate std::max<int, long int>.

2 possible solution:

add a static_cast<> around literals
add numeric limits into our language

See #1282
@havogt havogt added triage: bug Something isn't working module: frontend Frontend subpackage gt4py.next Issues concerning the new version with support for non-cartesian grids. labels Jul 18, 2023
@tehrengruber
Copy link
Contributor

This is also an option: #827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gt4py.next Issues concerning the new version with support for non-cartesian grids. module: frontend Frontend subpackage triage: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@havogt @tehrengruber