-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Components][Ingredients][Lists] #14
Comments
@vadim9999 are you assigned to this task? |
@atherdon you gave me this task in facebook |
ok, assigning you then |
@atherdon |
sure. |
@atherdon Can you give more details? I created component ListLayouts for this subtask. What should I add or delete? In PR GroceriStar/react-shopping-list-template#169 |
hold on, merging for now - will take a look a bit later. by first view - looks ok |
Should I create List with checkboxes? It's will be a component that sorted items? property status has 'all' 'active' 'purchased'? If I will pass status purchased It's render all item that property isChecked: true? |
i'm not sure... the reason why i'm slowing down tasks from this project - because i need to spend some time in order to review whole progress and compare it with notes from my papers. it'll take me a lot of time and i'm overwhelmed. |
if you think you're ok with all this list components, you can start composing all this code together. OR! we can move all of this components into separated package, so it'll later easy to use. |
I think it's ok with all components |
will we move it into a separated repo or do you want to keep it here? |
read this article: https://blog.bitsrc.io/tiny-components-what-can-go-wrong-d6aa42d71370 |
OK, so we create and display at examples page our components or blocks, that we'll use.
For sure, some of them components works not a 100% correct, so feel free to change their logic.
At previous task was important to just create them, right now we'll make them work as we need it.
i want to have a separated examples page, related to different type of lists, that we'll have.
I'm ok to have each of this list as a separated component. But if you want to dig more - we can talk about making one list, and just pass into it a different sub-components.
We had 3 lists at examples before:
Goal for List with link - display link and cover onClick events for each list item
Goal for List with edit to have list item with title and link "Edit" and cover onClick event too
Goal for List with Delete to have list item with title and link "Delete".
later we'll combine this functionality, but not now. I want to have as much as each elements that can be easy developed.
Notes:
Inside the Item(abstract) title can be not just a simple text, like an Ingredient name. So we cannot just display it at tag as {prop.title}. we should have a method that will return it. so later we can extend it into something else.
Some of the created components are not necessary. But deleting them not necessary too :) We can re-program them, so they will work as we need it.
text with id - it's should be one component, like Label, but we should be able to put some wrapper into it. so it's displaying text, but receiving 2 props: text and id from the parent component.
--
Autocomplete - we should compare this component with autocomplete from antd.
again, it can be one list with different item layouts. but logic is similar - display items + have some methods to handle additional interactions
When you click on checkbox -> text should be
text-decoration: line-through;
and status also changed to purchased for this item
when we have a drag-n-drop -> order should be adjusted too.
btw, order managed at list methods.
When you click on Edit -> right now we'll just have console log of data, related to this item...
When you click on Delete -> we should delete an item from the list, but we should put some blank method, that we'll use later in order to send a query to our server(that method should receive props with different ids)
For sure, this query will go from methods, specified at list component and delete link onClick will share it with parents - sharing ids(for sure)
The text was updated successfully, but these errors were encountered: