-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guake window opens in the middle of screen in Ubuntu when using Wayland #1844
Comments
@lapisdecor I was getting the same issue, which brought me here. However, our environments are not the same: $ guake --supportGuake Version: 3.7.0 Vte Version: 0.64.0 Vte Runtime Version: 0.64.0 GTK+ Version: 3.24.28 GDK Backend: GdkX11.X11Display Desktop Session: gnome-xorg Display: :1 RGBA visual: True Composited: True
Because of that, I started testing and found something that worked for me (and might work for you) was the following:
|
I'm getting the same behavior on Ubuntu 21.04. Using Gnome-tweak-tool if I set: I can drag it to the correct (top bar) location, but after I hide it, it will reappear in the center again If using Gnome-tweak-tool I disable the "Center new windows" setting, Then new windows will appear somewhere else on screen, but still not in the correct location. Note I've always used the "center new windows" setting, but it was never a problem with Guake until Ubuntu 21.04. $ guake --supportGuake Version: 3.6.3 Vte Version: 0.62.3 Vte Runtime Version: 0.62.3 GTK+ Version: 3.24.25 GDK Backend: gi.GdkWaylandDisplay Desktop Session: ubuntu Display: wayland-0 RGBA visual: True Composited: True
|
A patch that may fix this has just been merged. Can you confirm whether or not this is fixed in the current git main? If you can't compile, updates when the next version is released are also welcome. |
Pressing F11 multiple times eventually puts the window in the top position but if I press F12 again it goes to the center.
|
I believe this is an won't fix for Wayland, as in Wayland didn't provide absolute coordinate system, please see: #1632 (comment) |
The information in that issue seems to be wrong or outdated. Can confirm this is working correctly for me in Gnome+Wayland after disabling "Center new Windows" in gnome-tweak-tool as suggested by @ryanerwin. Inclined to think this is a bug with gnome-tweak-tool's ability to identify and exempt floating windows under Wayland. |
Can original reporter confirm if this fixes the issue? |
I can confirm that when I disable "Center new Windows" on gnome-tweak-tools the problem disapears and Guake window works fine. |
Alright, closing since problem apparently came from another program. |
I take it all back--I've raised this issue against gnome-shell but we've determined it is in fact guake that's the culprit. Though there is code to force guake to use the "x11 backend", it doesn't seem to be working properly, as I'm still seeing Wayland: $ guake --supportGuake Version: 3.6.3 Vte Version: 0.64.2 Vte Runtime Version: 0.64.2 GTK+ Version: 3.24.30 GDK Backend: gi.GdkWaylandDisplay Desktop Session: ubuntu Display: wayland-0 RGBA visual: True Composited: True
The positioning only superficially appears to work when "center-new-windows" is disabled because Wayland happens to place the window at the top-left corner. You will see if you try to position it elsewhere, or set the width less than 100%, it does not work. On the other hand, if I force it to use the x11 backend as suggested in @mlouielu 's linked comment, I can position it freely. So the bug here seems to be that the (Postscript: I don't know much about the state of affairs with Wayland beyond it being my desktop's default, but when you say "this is a WONTFIX for Wayland," I take that to mean this functionality cannot be implemented on a system using Wayland. In fact, it can work on such a system, or at least one using |
GDK_BACKEND is not beeing set here:
https://github.com/Guake/guake/blob/cbace1174292ff40e8c98b37000ec61c329c8f32/guake/terminal.py#L124
but it looks like this was a fix of another bug.
|
From your guake --support output, I see the version is slightly behind:
The code you linked to was added in 3.8, so it won't be in the version of Guake that you are currently running and getting your I think you'll find that updating to 3.8 does do the force as expected, although it has also been the subject of some amount of objection; see #1934. I created #1963 removing the line and related code in response to it so that removing the x11 force can enter consideration and anyone who has objections can voice them, but it hasn't gotten much discussion in favor or against it in the PR, so #1934 would probably be the place to go if you want to duke it out with the people in favor of actually for real removing the line. My ancient machine is running cinnamon, xorg, haven't yet actually had the chance to see a guake wayland issue for myself since cinnamon fully doesn't support wayland but I'm in for an upgrade from my 11 year old machine soon and I'll probably choose a DE that does support wayland for the new machine so I can actually join in on this and test fixes on my own machine instead of just taking other people's word that their code/recommended change works. |
I don't really know what I'm talking about, I didn't test it. I don't know the way Guake works, I'm new to this project; I just wanted to help, so I did a search of the repository for GDK_BACKEND to find places where it might get set and I only find that one. |
oh my new machine's already in the mail and eagerly awaited, just taking a while. You can get a version that uses x11 properly by default by grabbing the latest version of Guake, it's just somewhat contested whether it should be default or not. |
Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Guake.
For how to run the latest Guake in your computer, please refer to Install from source.
Describe the bug
Guake window opens in the middle of screen in Ubuntu when using Wayland
Expected behavior
Guake window opens on the top of the screen
Actual behavior
It opens on the middle of the screen
To Reproduce
Install Ubuntu 21.04 beta or Ubuntu 20.04, install guake and press F12
Please run
$ guake --support
, and paste the results here. Don't put backticks (`
) around it! The output already contains Markdown formatting. And make sure you run the command OUTSIDE the Guake.$ guake --support
Guake Version: 3.6.3
Vte Version: 0.62.3
Vte Runtime Version: 0.62.3
GTK+ Version: 3.24.25
GDK Backend: gi.GdkWaylandDisplay
Desktop Session: ubuntu
Display: wayland-0
RGBA visual: True
Composited: True
The text was updated successfully, but these errors were encountered: