Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods Overlap for Kotlin Code #426

Open
embydextrous opened this issue Aug 8, 2024 · 4 comments
Open

Methods Overlap for Kotlin Code #426

embydextrous opened this issue Aug 8, 2024 · 4 comments

Comments

@embydextrous
Copy link

embydextrous commented Aug 8, 2024

We are seeing method line numbers overlapping for Kotlin files (see bold part below).
Due to this the deobfuscation doesn't work well and get multiple deobfuscated stackframes for a single obfuscated stackframe causing confusion while debugging.

For ex: for line 214 we get onStart, update and get methods in the deobfuscated trace.

Is this a known issue or compatibility issues between proguard and kotlin version? We are using Kotlin 1.9 and Proguard 7.0.0 , gradle 7.2.

For Kotlin files

(com.google.gson.Gson,com.example.simplestore.presidio.RxSimpleStore,com.example.common.base.Clock,com.example.app_lifecycle.core.AppLifecycleProvider,com.example.core.UComponentCoreParameters,com.example.analytics.core.PresidioAnalytics) ->
> 93:387:void onStart(com.example.rib.core.WorkerScopeProvider) -> a
136:138:void onStop() -> az_
144:388:void update(java.lang.String,com.example.core.data.UComponentHolder) -> a
196:236:io.reactivex.Observable get(java.lang.String) -> a

@mrjameshamilton
Copy link
Collaborator

Hi @embydextrous ! Can you share a full sample that reproduces the isssue?

@embydextrous
Copy link
Author

embydextrous commented Aug 9, 2024

Hi @embydextrous ! Can you share a full sample that reproduces the isssue?

Do you need the mapping file and raw stacktrace?

deobfuscated.txt
obfuscated.txt
2d99cb10-4897-11ef-bcc6-0f1a076ae26d.txt.zip Mapping file (zipped due to large size)

From the obfuscated stacktrace:

at com.uber.car.map.core.overlay.e.a(SourceFile:133)

the above line results into multiple lines in deobfuscated stacktrace

at com.uber.car.map.core.overlay.CarMapOverlayWorker.onStart(CarMapOverlayWorker.java:133)
at com.uber.car.map.core.overlay.CarMapOverlayWorker.subscribeToMapChangesWithVisiblePaddingChangeAPI(CarMapOverlayWorker.java:133)
at com.uber.car.map.core.overlay.CarMapOverlayWorker.onStop(CarMapOverlayWorker.java:133)

in the mapping.txt line no. 133 corresponds to all these 3 methods.

@embydextrous
Copy link
Author

Hi @mrjameshamilton Any updates here?

@embydextrous
Copy link
Author

Hello @mrjameshamilton Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants