Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the IP solver interface code. #3

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

GunnarFarneback
Copy link
Owner

  • Repair the CBC backend. (It tried to pass "solver_options" literally to CBC.)
  • Don't pop! from solver_options; it mutates the caller's variable. If the caller tries to use it for a second call without recreating it, it won't work the same.
  • Set the algorithm controlled solver attributes directly instead of having them as a default for solver_options, which could easily get lost when that is customized. It's still possible to override them with explicit solver_options.
  • Get rid of the name conversions and send all solver_options as raw solver attributes.
  • Test the JuMP backend.
  • Document the JuMP backend and solver_options.

@GunnarFarneback GunnarFarneback mentioned this pull request Nov 17, 2024
@jd-foster
Copy link
Contributor

Looks good - thanks for this follow-up. This is exactly how I would have tried to do it, but you've done it better instead!

@GunnarFarneback GunnarFarneback merged commit 8970198 into master Nov 18, 2024
9 checks passed
@GunnarFarneback GunnarFarneback deleted the revise_optimizers branch November 18, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants