Return 404 when user is not found on avatar (go-gitea#21476)

- Backport go-gitea#21476 - Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found.
Gusted · Oct 16, 2022 · 359c037 · 359c037
1 parent f48fda8
commit 359c037
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/routers/web/user/avatar.go b/routers/web/user/avatar.go
@@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
  if strings.ToLower(userName) != "ghost" {
  var err error
  if user, err = user_model.GetUserByName(ctx, userName); err != nil {
+ if user_model.IsErrUserNotExist(err) {
+ ctx.NotFound("GetUserByName", err)
+ return
+ }
  ctx.ServerError("Invalid user: "+userName, err)
  return
  }