Use strings.Cut for GIT_PROTOCOL value

Gusted · Gusted · commit d5aeafd669d9 · 2022-08-02T22:14:10.000+02:00
- As per go-gitea#20616 (comment)
diff --git a/modules/ssh/ssh.go b/modules/ssh/ssh.go
@@ -78,8 +78,7 @@ func sessionHandler(session ssh.Session) {
 	gitProtocol := ""
 	for _, env := range session.Environ() {
 		if strings.HasPrefix(env, "GIT_PROTOCOL=") {
-			// The value would be version=2, so using normal split doesn't work here.
-			gitProtocol = strings.SplitN(env, "=", 2)[1]
+			_, gitProtocol, _ = strings.Cut(env, "=")
 			break
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,7 @@ func sessionHandler(session ssh.Session) {`
`78`	`78`	`gitProtocol := ""`
`79`	`79`	`for _, env := range session.Environ() {`
`80`	`80`	`if strings.HasPrefix(env, "GIT_PROTOCOL=") {`
`81`		`- // The value would be version=2, so using normal split doesn't work here.`
`82`		`- gitProtocol = strings.SplitN(env, "=", 2)[1]`
	`81`	`+ _, gitProtocol, _ = strings.Cut(env, "=")`
`83`	`82`	`break`
`84`	`83`	`}`
`85`	`84`	`}`