Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Coverage separation and needs to ignore some files #91

Open
JhChoy opened this issue Feb 19, 2019 · 1 comment
Open

Coverage separation and needs to ignore some files #91

JhChoy opened this issue Feb 19, 2019 · 1 comment
Assignees
@JhChoy
Labels
bug Something isn't working infrastructure CI, etc

Comments

@JhChoy
Copy link
Contributor

JhChoy commented Feb 19, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Coverages of vvisp and vvisp-utils are separated, so coverall does not report coverage of whole packages.
Also, in vvisp, coverage reporter checks temporary generated files contractApis like below:
image

Expected behavior

  1. Unify coverages of each package
  2. Ignoring generated files in contractApis/ dir.

Environment


vvisp version: v0.3.0


Environment:
- Node version: 10.15.2
- Operating system: Mac OSX
@JhChoy JhChoy added bug Something isn't working infrastructure CI, etc labels Feb 19, 2019
This was referenced Feb 25, 2019
Merged
Merged
@JhChoy JhChoy self-assigned this Feb 28, 2019
@JhChoy
Copy link
Contributor Author

JhChoy commented Feb 28, 2019 •
edited
Loading

CI ignores some files now at #101, but separation problem still exists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JhChoy JhChoy

Labels
bug Something isn't working infrastructure CI, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JhChoy