Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry wrongly assumes the connection is in a disconnected state #37

Open
starbelly opened this issue Dec 16, 2021 · 0 comments
Open

Comments

@starbelly
Copy link
Contributor

Currently a lot of places where a telemetry call is made assumes the state of the connection is disconnected.

Example :

%{status: :disconnected, error: error, context: "send message failure"},

The fact is we simply don't know if that's true. We could have a better idea if we checked a lot of error codes, but without doing that, we can't assume we're disconnected.

It may be we might be in a better position as far as avoiding error code checking to deduce the status of the socket if we made use of {:active, :once} on in the client, even still there will be cases where we won't be sure unless we poll the socket (i.e., try to perform a read and see what we get).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant