You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MLLP.Receiver for the most part is solid. There's possibly at least one edge case lurking in regard to the buffer not being ditched or a shutdown ensuing when unexpected data is received.
There's also an important optimization that should happen. The optimization isn't a big deal when messages are small, but on the server side, the messages received can indeed be quite large (think base64 encoded radiology images as an example). Said optimization merely using an io list as a buffer vs the current implementation.
We may also want to consider taking out certain parts which will never be used. Specifically, this application is supposed to be all about MLLP, thus everything must be encapsulated according to the specification, and it's only the dispatcher that cares about what's between the header and trailer. IMHO if other protocols are to be supported, this is probably not the application to do that in.
The text was updated successfully, but these errors were encountered:
MLLP.Receiver for the most part is solid. There's possibly at least one edge case lurking in regard to the buffer not being ditched or a shutdown ensuing when unexpected data is received.
There's also an important optimization that should happen. The optimization isn't a big deal when messages are small, but on the server side, the messages received can indeed be quite large (think base64 encoded radiology images as an example). Said optimization merely using an io list as a buffer vs the current implementation.
We may also want to consider taking out certain parts which will never be used. Specifically, this application is supposed to be all about MLLP, thus everything must be encapsulated according to the specification, and it's only the dispatcher that cares about what's between the header and trailer. IMHO if other protocols are to be supported, this is probably not the application to do that in.
The text was updated successfully, but these errors were encountered: