Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-working MLLP.Receiver #69

Open
starbelly opened this issue Jul 15, 2023 · 0 comments
Open

Consider re-working MLLP.Receiver #69

starbelly opened this issue Jul 15, 2023 · 0 comments

Comments

@starbelly
Copy link
Contributor

MLLP.Receiver for the most part is solid. There's possibly at least one edge case lurking in regard to the buffer not being ditched or a shutdown ensuing when unexpected data is received.

There's also an important optimization that should happen. The optimization isn't a big deal when messages are small, but on the server side, the messages received can indeed be quite large (think base64 encoded radiology images as an example). Said optimization merely using an io list as a buffer vs the current implementation.

We may also want to consider taking out certain parts which will never be used. Specifically, this application is supposed to be all about MLLP, thus everything must be encapsulated according to the specification, and it's only the dispatcher that cares about what's between the header and trailer. IMHO if other protocols are to be supported, this is probably not the application to do that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant