Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise errors on failures in loading data #111

Closed
jonrkarr opened this issue Dec 10, 2021 · 3 comments
Closed

Raise errors on failures in loading data #111

jonrkarr opened this issue Dec 10, 2021 · 3 comments

Comments

@jonrkarr
Copy link

jonrkarr commented Dec 10, 2021

hsload currently prints console messages when data loading fails (e.g., request entity too large):

except (IOError, TypeError) as e:

To make errors easier to detect, it would be helpful for hsload to exit with a non-zero exit code such as by calling sys.exit(1) after L532 above.

@jreadey
Copy link
Member

jreadey commented Nov 23, 2022

See commit: 994cffc.
new behavior is for hsload to fail on an error unless the --ignore flag is used.
This is in the aggregate branch - will close issue once merged with master.

@jreadey
Copy link
Member

jreadey commented Nov 24, 2022

Fix is in master.

@jreadey
Copy link
Member

jreadey commented Dec 1, 2022

Closing - fix is in the 0.12.0 release on PyPI.

@jreadey jreadey closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants