Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes aren't working #73

Closed
afortiorama opened this issue Sep 6, 2017 · 2 comments
Closed

Some changes aren't working #73

afortiorama opened this issue Sep 6, 2017 · 2 comments

Comments

@afortiorama
Copy link
Member

afortiorama commented Sep 6, 2017

The structure of the parameters has changed completely. The problems I found are related to some parameters but they might affect other parameters.

  1. Some parameters have been renamed without warning example condor_admin_email has become admin_email

  2. in init.pp to get the parameters from hiera one has to go through params.pp parameters not all the parameters in init.pp are assigned an htcondor::params::parameter in particular

  • $use_ssl_auth = $htcondor::use_ssl_auth,
  • $use_ssl_auth = $htcondor::params::use_ssl_auth,
    needs to be corrected
  1. several parameters has "undef" in the default. This doesn't seem to work correctly for all parameters. For example leave_job_in_queue doesn't pass the if statement in the template. undef is considered by Ruby as if the variable is defined. Replacing undef with false gives the right result
  • $leave_job_in_queue = hiera('leave_job_in_queue', undef)
  • $leave_job_in_queue = hiera('leave_job_in_queue', false)

I have the impression the same might be for other variables.

  1. Some parameters have disappeared? I cannot find where the worker_nodes array is used anymore and why if I remove a WN from there it still appears. Has it been renamed too? I'm not using the firewall as we have our own classes.

  2. usex509userproxy also seems to have disappeared from the condor_config.local.

thanks

cheers
alessandra

@afortiorama
Copy link
Member Author

Even computing_elements has disappeared.

@afortiorama
Copy link
Member Author

ok I've found both computing_elements -> schedulers and worker_nodes -> workers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants