Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-branch Terminology cache location could cause issues with CI builds #88

Open
dotasek opened this issue Aug 17, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@dotasek
Copy link
Collaborator

dotasek commented Aug 17, 2022

When the Publisher finds the environment variables set by Azure CI builds, it automatically creates a Terminology cache directory at ~/.fhir/{ghOrg}/{ghRepo}/{ghBranch}.

This results in two issues:

  1. This directory will persist and any contents will be present if the PR is rebuilt. If the cache contains any invalid responses, the next build on that PR could pick those up.

  2. The cache is located on the agent machine, NOT in the generated agent work directory. If the first build of the PR happened on GCP1, then only GCP1 will have the cached responses. If the next build runs on GCP2, the cache will be regenerated on GCP2 and will not re-use the contents of GCP1.

According to @grahamegrieve, the intention of this location was to re-use the cache. This should speed up subsequent builds. The cost of this is the possibility of issue 1 occurring, but the tradeoff has been deemed to be worth it.

However, the advantage of cache re-use is unavailable now that we have multiple agent machines, since issue 2 is very much occurring.

A location re-usable across builds would be ideal.

@dotasek dotasek added the bug Something isn't working label Aug 17, 2022
@dotasek dotasek self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant