Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision error in output #8

Open
dl5415 opened this issue Mar 15, 2019 · 5 comments
Open

Precision error in output #8

dl5415 opened this issue Mar 15, 2019 · 5 comments

Comments

@dl5415
Copy link

dl5415 commented Mar 15, 2019

After parallelising inside the frame_to_object_stream function, we witness some precision error (6th decimal place) when comparing the events output to that of the benchmark. Should this be taken into consideration?
Screenshot from 2019-03-15 22-25-53

@jjd06
Copy link
Contributor

jjd06 commented Mar 18, 2019

This is something you can (should?) discuss in your report. Small errors here might not matter at all as far as the final output is concerned, or they might break everything. There might be a tradeoff between speedup and accuracy. Is there a knob potentially available for the client to tune this tradeoff according to their needs?

@AlexMontgomerie
Copy link

Is there any automated checking of correctness for any implementations? If so, are we given an error margin, and can we be told this margin before the deadline? Else, are scripts designed by us enough to validate the correctness of our implementation?

@jjd06
Copy link
Contributor

jjd06 commented Mar 21, 2019

I may run your code, and one of the things I may do as a result is compare the output to that of the reference. If it's completely wrong, that's clearly an issue, but if it's slightly different (due to e.g. instruction reordering, whether done explicitly or allowed to happen through the introduction of parallelism) then that should be discussed. So: it doesn't matter if the outputs differ, so long as you can explain why and, even better, if you can explain what that means in terms of application-level output.

@dl5415
Copy link
Author

dl5415 commented Mar 23, 2019

Thanks for the clarification. For outputs, are you referring to the .events files or the final mjpeg files. Because the output events may differ after speed-up, but the detected objects in the mjpeg files are consistent.

@jjd06
Copy link
Contributor

jjd06 commented Mar 25, 2019

The *.events files are the application-level outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants