Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalysisSampleCollection #101

Open
germa opened this issue May 25, 2018 · 2 comments
Open

AnalysisSampleCollection #101

germa opened this issue May 25, 2018 · 2 comments

Comments

@germa
Copy link
Collaborator

germa commented May 25, 2018

No description provided.

@germa
Copy link
Collaborator Author

germa commented Sep 10, 2018

Shouldn't we make the element AnalysisSampleCollection mandatory?

Currently it's facultative, but it has a mandatory child element Sample,
so effectively the element AnalysisSampleCollection also must be present.

Sometimes I see in PRIDE uploads .mzid files with missing Sample elements,
I assume because some implementers wrongly interpreted that must not be there because AnalysisSampleCollection is currently not mandatory.

Cheers,
Gerhard

@edeutsch
Copy link
Contributor

I don't know about this particular case, but in general in PSI XML formats (and XML schema) it is permissable to have a required subelement of an optional element. And this means that if the optional element is present, then it MUST have the required subelement. But if the optional element is left out, then there is no subelement. In others words, a required subelement does NOT imply that the parent element is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants