Don't show boss damage being applied if you aren't on a boss quest

[saraolson]

if im on a collection quest and i complete a task, it shows damage being accumulated in the toast after i complete each task. it should only show this if im on a boss quest.

[tjb]

ill take a look!

[tjb]

@saraolson is there an easy way to test this and reproduce it multiple times? any easy collection quests i can test with?

[saraolson]

@tjb sorry, missed this notification! i usually use the 'attack of the mundane' quest and just cancel it before i finish to test. new accounts get it at level 15.

[tjb]

ok ty! i will test next week and see if I can reproduce!

[tjb]

@saraolson i just purchased the first part of the 'attach of the mundane' quest, i started it and aborted it and i did not see any message. can you attach a video of how you start the quest? perhaps i am doing things wrong

[saraolson]

@tjb the problematic toast is only seen when you check off a task. so if you're on a collection quest, check a task and you'll see the toast includes a number by a sword icon. that indicates boss damage, but boss damage isnt relevant when you're on a collection quest.

(the note about quitting the quest before completing it is just so you dont lose the scroll while testing)

[tjb]

Ah ok cool this is super helpful thank you so much @saraolson. i believe i just misunderstood the ticket cause i always assumed the sword meant my characters damage increased and that is not the case!

i should have some free time this weekend/into next week to get a fix together!

Example: I do not have a quest started and I still see the sword icon after completing a task and i should not, correct?

[tjb]

perhaps a domain question but why do we use progressDelta as damage? is there some documentation around the definition of the models that could give more insight?

additionally i am not on a question and i am getting progressDelta off of TaskResponseTempProtocol. should this only be present if i am on a quest with my party?

unsure if this is a question for @phillipthelen or @saraolson

[saraolson]

@tjb so we always want ppl to build quest 'progress' in the background because we will apply it if they start a quest later that day. we just dont want to show it if its not relevant.

does that help?