Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs in calendar event descriptions aren't linkified #104

Open
AaronC81 opened this issue Apr 3, 2020 · 4 comments
Open

URLs in calendar event descriptions aren't linkified #104

AaronC81 opened this issue Apr 3, 2020 · 4 comments
Labels
frontend Relating to the HTML, CSS, and JS which runs in the user's browser

Comments

@AaronC81
Copy link
Member

AaronC81 commented Apr 3, 2020

If a calendar event description contains a URL, it isn't converted into a clickable link by the calendar on the home page. This is a regression from Google Calendar's embed.

@LukeMoll LukeMoll added the frontend Relating to the HTML, CSS, and JS which runs in the user's browser label Oct 29, 2020
@LukeMoll
Copy link
Member

@AaronC81 this appears to be fixed in the live version of the website, can you confirm? Also do you know which commit fixed this?

@AaronC81
Copy link
Member Author

This particular issue isn't fixed yet. The home-page calendar does respect HTML formatting, so if an event description contains an <a> tag then it'll be clickable on the site. But if it just contains a plain-text unformatted link, Google Calendar shows this as a clickable link, but our embed won't.

@AaronC81 AaronC81 changed the title Links in calendar event descriptions aren't linkified URLs in calendar event descriptions aren't linkified May 14, 2021
@LukeMoll
Copy link
Member

Ah noted, thanks for the update.

@JMAlego
Copy link
Member

JMAlego commented Nov 3, 2021

Would this not be better solved in https://github.com/HackSoc/calendar-api given it can use a ruby library to do this in the middle, less work for the client etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Relating to the HTML, CSS, and JS which runs in the user's browser
Projects
None yet
Development

No branches or pull requests

3 participants