Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping problems #206

Open
sersorrel opened this issue Feb 24, 2022 · 0 comments
Open

Escaping problems #206

sersorrel opened this issue Feb 24, 2022 · 0 comments
Labels
backend Relating to the code which runs on the server and generates the site bug Unexpected behaviour on client or server side

Comments

@sersorrel
Copy link
Member

hacksoc.org/templates/base.html.jinja2

Line 28 in c83e30e

<meta property="og:description" content="{{lede|trim}}">

i am pretty sure this should be {{lede|trim|e}}, to avoid a problem which can be observed here: https://www.hacksoc.org/news/2014-01-20-bytemark-sponsorship.html

but i strongly suspect there are similar problems lurking elsewhere, since as far as i can tell jinja's autoescape feature is not enabled

we should probably enable autoescape and see what breaks, and/or audit all current uses of jinja interpolation
@sersorrel sersorrel added the bug Unexpected behaviour on client or server side label Feb 24, 2022
@LukeMoll LukeMoll added the backend Relating to the code which runs on the server and generates the site label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Relating to the code which runs on the server and generates the site bug Unexpected behaviour on client or server side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeMoll @sersorrel