-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import 'zone.js' which may cause duplicate #99
Comments
Well Zone should be loaded prior Angular. So every user should do it for himself before. IMHO no other components should reference Zone directly. |
Getting the same error after install 6.0.0-beta.1
|
@jtcrowson having this same issue. any quick fixes |
@richie50 try to comment out all the import 'zone.js' from the source |
@vincent-cm when i comment out zone js from my package.json my app doesn't load at all. I get zone js cannot be found. Did you experience that? |
@richie50 I mean the source code from ./node_modules/ng2-idle/ but not recommend, better to download the ng2-idle source and insert into your own project. |
@vincent-cm thanks will do 👍 |
Appreciate the workaround, but of course, don't want to commit my node_modules to source control. @hackedbychinese is this workaround in consideration for implementation? |
I used patch-package for it. It's amazing for doing small patches in published libs. |
Good call @sherlock1982. Thanks!! |
I have a fix. i will be submitting a pull request soon. Works with angular 6.0.3. Pull request submitted please review @sherlock1982 @vincent-cm @jtcrowson @hackedbychinese |
After installing the 6.0.0-beta.1
The AoT build will throw an error at runtime:
Uncaught Error: Zone already loaded.
As ./modules/core/src/interruptsource.ts has zone.js imported which I think it is not necessary
The text was updated successfully, but these errors were encountered: