New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Brian Coventry's fixes to the EC50 code? #9

Open

Haddox opened this issue Aug 27, 2019 · 0 comments

Owner

Haddox commented Aug 27, 2019

Bug fixes:
-Don't multiply frac_sel_pop by matching_sequences (largest population effect? but also more questionable?)
-Normalize response function to compare zero protease to X protease
-Don't correct EC50 values to fix global frac_sel_pop (largest individual effect?)

What sanity checks should we perform?

Manually check a random subset. Look at the counts. See which EC50 method looks better given the counts.
Make sure that it doesn't change past results.
-Brian did this for Gabe's data. It was highly correlated, but there were a fraction of datapoints that changed by a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment