Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EAP build #107

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Fix EAP build #107

merged 1 commit into from
Feb 18, 2018

Conversation

vkhramtsov
Copy link
Contributor

@vkhramtsov vkhramtsov commented Feb 16, 2018 •
edited
Loading

Fixes #105

@vkhramtsov vkhramtsov changed the title Fix EAP build WIP:Fix EAP build Feb 16, 2018
@vkhramtsov
Copy link
Contributor Author

@Haehnchen Would you be so kind to review this PR and check result? Thank you

@vkhramtsov vkhramtsov changed the title WIP:Fix EAP build Fix EAP build Feb 18, 2018
Haehnchen
Haehnchen reviewed Feb 18, 2018
View reviewed changes
travis.sh

# TODO: extract latest builds for plugins from eap site they are not public
# https://confluence.jetbrains.com/display/PhpStorm/PhpStorm+Early+Access+Program
# You can extract them from pages:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Haehnchen Haehnchen merged commit 65d848e into Haehnchen:master Feb 18, 2018
@vkhramtsov vkhramtsov deleted the bugfix-cannot-build-plugin-for-latest-EAP branch February 18, 2018 21:14
@rdohms rdohms mentioned this pull request Feb 19, 2018
Closed
@lloy0076 lloy0076 mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haehnchen Haehnchen Haehnchen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkhramtsov @Haehnchen