Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated class is not strike-out in the annotations suggested classes. #156

Closed
PhilETaylor opened this issue Nov 10, 2019 · 5 comments · Fixed by #157
Closed

Deprecated class is not strike-out in the annotations suggested classes. #156

PhilETaylor opened this issue Nov 10, 2019 · 5 comments · Fixed by #157

Comments

@PhilETaylor
Copy link

PhilETaylor commented Nov 10, 2019

forked from Twitter here: https://twitter.com/myPhilTaylor/status/1192825455105191938

I believe that the annotations plugin is at fault - Im guessing.

Basically when starting an annotation in Symfony project for @Route I would expect to see the deprecated class name striked-out and the non deprecated class name as normal.

Please watch this video to understand the problem: http://screenshot.myjoom.la/7beee936aeb2

The video first shows how the deprecated class shows when writing PHP code,

Screenshot 2019-11-10 at 20 15 44

Secondly it shows the same list of classes when in an annotation

Screenshot 2019-11-10 at 20 16 01

The difference between them is that the deprecated class is not strike-out in the annotations suggested classes.

Is this an annotations plugin issue or a phpstorm issue?

@cedricziel
Copy link
Collaborator

Interesting proposition 👍

@PhilETaylor
Copy link
Author

Awesome - thanks for the quick change - you do not understand how helpful this will be 🎉

Although, its now just striking out the class name and not the name space:

This is what your plugin is doing:

Screenshot 2019-11-11 at 20 01 55

and compare that with phpStorm:
Screenshot 2019-11-11 at 20 03 36

Any chance you could match theirs where the whole namespace/row is strike out?

@PhilETaylor
Copy link
Author

Also phpStorm puts deprecated classes LAST, can you do that? :-)

@cedricziel
Copy link
Collaborator

Hmm.. also interesting. Please open another ticket so we don't forget :)

@PhilETaylor
Copy link
Author

Thanks for considering it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants