Imported classes are marked as unused when used for constant

[stefnoten]

When importing classes for using its constants in an annotation, the imports are incorrectly marked as unused. Example:

namespace A;

use JMS\DiExtraBundle\Annotation as DI;
use Some\Namespace\To\MyEvents; // incorrectly marked as unused

class SomeClass {
    /** @DI\Observe(MyEvents::SOME_EVENT) */
    public function doSomething() {
    }
}

I'm using the latest version of the plugin (2.6.2). This makes it impossible to let the IDE automically optimize imports (e.g. via the shortcut or on commit). When not using this feature, it is still error-prone because mistakenly removing such an import will break the code.

[thebigb]

Dupe of #18, #22 and #26?

Those issues have been silent for a while though.

[thebigb]

@Haehnchen, I would be willing to take a look at this, but could you provide a few pointers on where to look?

Additionally do you have any tips for debugging an extension like this? I tried debugging this plugin some time ago to figure out how it works, but most breakpoints that I would set would not go off.

[acelayawonnova]

@thebigb It is easy to reproduce. The doctrine/annotations package allows class constants to be passed to annotations, as in @stefnoten example, @DI\Observe(MyEvents::SOME_EVENT), the MyEvents::SOME_EVENT constant is a valid param.
However, in order to get it working, the use statement with the FQCN needs to be present, use Some\Namespace\To\MyEvents, but PhpStorm marks it as unused, making it easy to be accidentally removed, for example by automatically optimizing the use statements.

I hope that helps you :-)

[danez]

Can there anything be done about it? are there workarounds till this is fixed?

[Haehnchen]

done