disable_terminal_ui does not seem to work

[rondlite]

disable_terminal_ui in bridgeData.yaml does not seem to do anything.

I get the UI no matter what,
I also tried setting HORDE_DISABLE_TERMINAL_UI env var, with no luck.

As a result I can not background the process.

[tazlin]

• What values for disable_terminal_ui in bridgeData.yaml have you tried?
• What values for HORDE_DISABLE_TERMINAL_UI have you tried?
• Are other configuration options working?
• What OS is this?

[rondlite]

• What values for disable_terminal_ui in bridgeData.yaml have you tried?
• What values for HORDE_DISABLE_TERMINAL_UI have you tried?
• Are other configuration options working?
• What OS is this?

• tried setting true and also tried the false it was originally on
• tried true for the environment var
• all others options are working
• linux/ubuntu

[tazlin]

I don't see a readily apparent reason, but I made a minor change that might help. If you git pull and try again, and it still happens, I will investigate more.

[rondlite]

It did not fix it, I ended up doing quick dirty fix since needed to get my workers back online.
After however I found this line:

AI-Horde-Worker/worker/bridge_data/framework.py

Line 46 in 5cfa9b0

self.disable_terminal_ui = os.environ.get("DISABLE_TERMINAL_UI", "false") == "true"

which disables the terminal ui when the env var is false, logic is reversed here