Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling restarted requests does not work as intended #460

Open
arcaria opened this issue Oct 3, 2024 · 0 comments
Open

Canceling restarted requests does not work as intended #460

arcaria opened this issue Oct 3, 2024 · 0 comments

Comments

@arcaria
Copy link

arcaria commented Oct 3, 2024

From the conversation on discord (https://discord.com/channels/781145214752129095/1081743238194536458/1291430902450356285):
I noticed something while trying to add this to my worker. It seems that only requests/images that are in "waiting" can be canceled, so if any one of those goes from processing to restarted and back to processing endlessly then it can not be canceled. This can happen if the request has "is_possible": true
Managed to make my worker pseudo-crash, it didn't stop the execution like I wanted, but the processes crashed
The problem was that on restarting it, it would go on to pick that request again, even though I tried VERY hard to cancel it in https://aihorde.net/api/ with the delete endpoint /v2/generate/status/{id}, but it didn't work, the request could only be canceled when I stopped my worker completely and "is_possible" changed to false

quoting db0:
"Actually, any request will be cancelled. Cancelling a request sets its n to 0. However you're right that failing a cancelled request is an edgecase I hadn't considered as a reported fault on the horde does an n += 1. But theoretically should abort after 3 retries. Need to double-check that logic. If you can open an issue I'll follow-up"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant