Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "optimization" key #78

Open
db0 opened this issue Feb 24, 2024 · 1 comment
Open

Allow "optimization" key #78

db0 opened this issue Feb 24, 2024 · 1 comment
Labels
enhancement New feature or request refactor/code improvement A feature which primarily benefits contributors or integrators.

Comments

@db0
Copy link
Member

db0 commented Feb 24, 2024

I want to add a new key for models in the reference "optimization" which is optional, or "turbo", "lightning" etc

image
@tazlin
Copy link
Member

tazlin commented Feb 24, 2024

This is going to require making sure the 'legacy' -> 'new' format parsing caries arbitrary fields across during the conversion process in production, but fails during testing (so they can be explicitly defined in pydantic basemodels).

@tazlin tazlin added enhancement New feature or request refactor/code improvement A feature which primarily benefits contributors or integrators. labels Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor/code improvement A feature which primarily benefits contributors or integrators.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@db0 @tazlin