Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controlnet annotator nodes #180

Open
tazlin opened this issue Feb 6, 2024 · 0 comments
Open

Update controlnet annotator nodes #180

tazlin opened this issue Feb 6, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tazlin
Copy link
Member

tazlin commented Feb 6, 2024

Presently hordelib packages nodes for controlnet preprocessing. The inclusion of these nodes dates back to a time where there were limited options for accomplishing this goal. However, if you look closely at these packaged files, they diverge in a few key ways.

  • They use absolute hordelib namespaces where previously they would have used their own package namespace.
    • This is in part because these nodes are dynamically loaded by ComfyUI at runtime and ties into the same sort of PYTHONPATH issues that plague this project (due to ComfyUI not being a python library).
  • Some bad code to redirect downloads to the AIWORKER_CACHE_HOME dir.
  • At least one fix for horrendous performance

I would like to put this particular package to pasture and move on to a more up-to-date version. The same author released this package which, as I understand it, replaces the code base we currently package.

Some thoughts:

  • Does the potential replacement package
    • have performance problems?
    • have the ability to be packaged with no further trickery?
      • if not, can we find a way to dynamically inject the code changes that would be required?
    • have a way to avoid downloading files to random locations?
  • What pipeline changes are needed?
  • How do we bind these new nodes in an extensible way to our code?
    • What are the interfaces now?
    • What are the requirements for directly interacting with any of this code?
@tazlin tazlin added enhancement New feature or request help wanted Extra attention is needed labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant