Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging API to take out the performance burden #181

Closed
ethouris opened this issue Dec 4, 2017 · 0 comments
Closed

Refactor logging API to take out the performance burden #181

ethouris opened this issue Dec 4, 2017 · 0 comments

Comments

@ethouris
Copy link
Collaborator

ethouris commented Dec 4, 2017

The logging API even if turned off still causes evaluation of the arguments, which may cause a heavy performance burden.

The logging system, in case when turned off completely, should not evaluate arguments, as well as when particular log dispatched is disabled in the filter. This can be achieved by putting the if conditional directly in the macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethouris