Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Override global log level for a functional area #2673

Closed
Chardrazle opened this issue Feb 21, 2023 · 2 comments · Fixed by #2733
Closed

[FR] Override global log level for a functional area #2673

Chardrazle opened this issue Feb 21, 2023 · 2 comments · Fixed by #2733
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Milestone

Comments

@Chardrazle
Copy link

We had a scenario where the log produced from the SRT_LOGFA_BUF_RECV functional area produced a lot of noise ("RCV-DROPPED") at warning level.

We have several options to reduce this noise; however, none of them are ideal. For example:

  • Adjust the global logging level.
    This has the danger of then missing information across the board.
  • Switch off logging for the functional area.
    We may still be interested in seeing logs for the functional area at (e.g.) error level.
  • Perform our own filtering in the logging callback.
    This is likely to add an overhead.

It would be useful to be able to set a logging-level override for a functional area. This looks like it could be solvable (mainly) in the LogDispatcher::CheckEnabled method. For example, the single enabling flag for a functional area (in the bitset) could be changed to a logging-level that overrides the global level.

@Chardrazle Chardrazle added the Type: Enhancement Indicates new feature requests label Feb 21, 2023
@ethouris
Copy link
Collaborator

@maxsharabayko I think this is the time to make the solution provided in #2602 reusable.

@ethouris
Copy link
Collaborator

Ok, can you please check if the version submitted for #2674 fixes the problem well enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
3 participants