bug in arguments aextractor

phpmetrics · Sep 1, 2014 · d917dee · d917dee
1 parent 148a464
commit d917dee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Hal/Component/OOP/Extractor/MethodExtractor.php b/src/Hal/Component/OOP/Extractor/MethodExtractor.php
@@ -66,8 +66,13 @@ public function extract(&$n, TokenCollection $tokens)
             if(sizeof($elems, COUNT_NORMAL) == 1) {
                 list($name, $type) = array_pad($elems, 2, null);
             } else {
-                list($type, $name) = array_pad($elems, 2, null);
-
+                if('$' == $elems[0][0]) {
+                    $name = $elems[0];
+                    $type  = null;
+                    $isRequired = false;
+                } else {
+                    list($type, $name) = array_pad($elems, 2, null);
+                }
             }
 
             $argument = new ReflectedArgument($name, $type, $isRequired);

diff --git a/tests/Hal/Component/OOP/MethodExtractorTest.php b/tests/Hal/Component/OOP/MethodExtractorTest.php
@@ -150,6 +150,8 @@ public function provideCodeForNew() {
             array(array(), '<?php public function foo() { return 1; }')
             , array(array('A'), '<?php public function bar() { new A();  }')
             , array(array('A'), '<?php public function bar() { new A(1,2,3);  }')
+            , array(array(), '<?php public function bar($d = false) {  }')
+            , array(array(), '<?php public function bar($d = false) {  }')
         );
     }
 }