Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will LibLog be replaced? #1584

Open
HolisticDeveloper opened this issue Dec 10, 2019 · 5 comments
Open

Will LibLog be replaced? #1584

HolisticDeveloper opened this issue Dec 10, 2019 · 5 comments

Comments

@HolisticDeveloper
Copy link

I just read that LibLog has been deprecated (see damianh/LibLog#270). Has any thought be given yet to whether Hangfire will switch to Microsoft.Extensions.Logging or a different logging abstraction?

@odinserj
Copy link
Member

The rule #1 for logging in a framework – don't depend on any external package. Otherwise sooner or later there will be a breaking change in that package, and you'll have a version lock, where you can't upgrade without breaking all the current installations, and can't leave the current version, because newer projects will be unable to use it.

LibLog plays well as it's a simple source file and doesn't force you to have any external NuGet package references.

@kilroyFR
Copy link

Agreed with odinserj, microsoft.extension.logging is wired with others nugets, requires modification on all constructors for same functionality. Totally useless. On some of my personal projects i sticked on liblog.

@stijnherreman
Copy link

@odinserj any chance of reconsidering the use of Microsoft.Extensions.Logging? If not, I'll try upgrading the LibLog dependency to the latest version.

@odinserj
Copy link
Member

Unfortunately, there are breaking changes in the LibLog of the latest version, so it's currently not possible just to upgrade it. Hangfire.NetCore package provides an adapter for Microsoft.Extensions.Logging, so it works with it. One problem is current logging is the absence of structured logging, but anyway it should be addressed without introducing breaking changes.

@odinserj
Copy link
Member

Also, LibLog is added to Hangfire as sources, and there's no dependency on its NuGet package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants