Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Newtonsoft and integrate Microsofts System.Text.Json library #2305

Open
montelyno opened this issue Oct 11, 2023 · 6 comments
Open

Remove Newtonsoft and integrate Microsofts System.Text.Json library #2305

montelyno opened this issue Oct 11, 2023 · 6 comments

Comments

@montelyno
Copy link

Hi all,
first of all thank you very much for your great work! Highly appreciated!

Is there any option to remove Newtonsoft.Json and integrate the implementation from Microsoft in System.Text.Json?
We are removing the old serializer where ever possible and strictly use the new implementation, less dependencies and industry code scanners like FoD are more relaxed...

Thanks in advance for your effort and kind regards
Michael

@vvdb-architecture
Copy link

Perhaps there is another way of reformulating this request: redesign the next version of Hangfire to refactor the serialization (what is now SerializationHelper into a pluggable component. which can be implemented using whatever serialization mechanism you like.

Because today, it's System.Text.Json, but what will it be tomorrow?

Of course, there is more to it than that: Hangfire contains references to Newtonsoft-specific attributes in various other places.

  • Some of those can be renamed to .NET attributes that are also recognized by Newtonsoft. For example NonSerialized instead of JsonIgnore, DataMember instead of JsonProperty.
  • Other places will need some serious thinking.... that's why the version will most likely be bumped to 2 :-).

Oh if I only had the time...

@sabiland
Copy link

Because today, it's System.Text.Json, but what will it be tomorrow?

But Newtonsoft is a live project, I think it will be going on for a long time still.

@supergibbs
Copy link

Sounds like a good 2.0 goal!

Relates/Dupes to
#2202
#2033

@apavelm
Copy link

apavelm commented Dec 22, 2023

+1

@apavelm
Copy link

apavelm commented Dec 22, 2023

is a requested feature in the roadmap?

@lisandrogreco
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants